-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dnd-worldmap-removal) Added null checks for columns and fields. #53475
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Generated by Django 3.2.20 on 2023-07-24 21:37 | ||
|
||
from django.db import migrations | ||
|
||
from sentry.models import DashboardWidgetQuery | ||
from sentry.new_migrations.migrations import CheckedMigration | ||
|
||
|
||
def migrate_worldmap_widgets_to_table_widgets(apps, schema_editor): | ||
# World map visulization has display_type 5 | ||
widgetQueries = DashboardWidgetQuery.objects.select_related("widget").filter( | ||
widget__display_type=5 | ||
) | ||
|
||
for widgetQuery in widgetQueries: | ||
# Change widget display type from world_map:5 to table:4 | ||
widgetQuery.widget.display_type = 4 | ||
|
||
# Ensure condition has countr_code check | ||
if "has:geo.country_code" not in widgetQuery.conditions: | ||
widgetQuery.conditions = widgetQuery.conditions + " has:geo.country_code" | ||
|
||
# Add region and country_code columns | ||
if not widgetQuery.columns: | ||
widgetQuery.columns = [] | ||
if "geo.region" not in widgetQuery.columns: | ||
widgetQuery.columns.insert(0, "geo.region") | ||
if "geo.country_code" not in widgetQuery.columns: | ||
widgetQuery.columns.insert(0, "geo.country_code") | ||
|
||
# Add region and country_code as fields | ||
if not widgetQuery.fields: | ||
widgetQuery.fields = [] | ||
if "geo.region" not in widgetQuery.fields: | ||
widgetQuery.fields.insert(0, "geo.region") | ||
if "geo.country_code" not in widgetQuery.fields: | ||
widgetQuery.fields.insert(0, "geo.country_code") | ||
|
||
widgetQuery.widget.save() | ||
widgetQuery.save() | ||
|
||
|
||
class Migration(CheckedMigration): | ||
# This flag is used to mark that a migration shouldn't be automatically run in production. For | ||
# the most part, this should only be used for operations where it's safe to run the migration | ||
# after your code has deployed. So this should not be used for most operations that alter the | ||
# schema of a table. | ||
# Here are some things that make sense to mark as dangerous: | ||
# - Large data migrations. Typically we want these to be run manually by ops so that they can | ||
# be monitored and not block the deploy for a long period of time while they run. | ||
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to | ||
# have ops run this and not block the deploy. Note that while adding an index is a schema | ||
# change, it's completely safe to run the operation after the code has deployed. | ||
is_dangerous = False | ||
|
||
dependencies = [ | ||
("sentry", "0519_remove_repo_name_constraint"), | ||
] | ||
|
||
operations = [ | ||
migrations.RunPython( | ||
migrate_worldmap_widgets_to_table_widgets, | ||
migrations.RunPython.noop, | ||
hints={"tables": ["sentry_dashboardwidgetquery", "sentry_dashboardwidget"]}, | ||
), | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're around the 10k row count. You could hit a migration timeout when updating rows. If you wanted to be totally safe an
is_dangerous = True
migration would safer albeit much slower.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'd rather be safe. How much longer would it take @markstory?