Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dnd-worldmap-removal) Added null checks for columns and fields. #53475

Merged
merged 2 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
will then be regenerated, and you should be able to merge without conflicts.

nodestore: 0002_nodestore_no_dictfield
sentry: 0519_remove_repo_name_constraint
sentry: 0520_migrate_worldmap_widgets
social_auth: 0002_default_auto_field
66 changes: 66 additions & 0 deletions src/sentry/migrations/0520_migrate_worldmap_widgets.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
# Generated by Django 3.2.20 on 2023-07-24 21:37

from django.db import migrations

from sentry.models import DashboardWidgetQuery
from sentry.new_migrations.migrations import CheckedMigration


def migrate_worldmap_widgets_to_table_widgets(apps, schema_editor):
# World map visulization has display_type 5
widgetQueries = DashboardWidgetQuery.objects.select_related("widget").filter(
widget__display_type=5
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're around the 10k row count. You could hit a migration timeout when updating rows. If you wanted to be totally safe an is_dangerous = True migration would safer albeit much slower.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'd rather be safe. How much longer would it take @markstory?


for widgetQuery in widgetQueries:
# Change widget display type from world_map:5 to table:4
widgetQuery.widget.display_type = 4

# Ensure condition has countr_code check
if "has:geo.country_code" not in widgetQuery.conditions:
widgetQuery.conditions = widgetQuery.conditions + " has:geo.country_code"

# Add region and country_code columns
if not widgetQuery.columns:
widgetQuery.columns = []
if "geo.region" not in widgetQuery.columns:
widgetQuery.columns.insert(0, "geo.region")
if "geo.country_code" not in widgetQuery.columns:
widgetQuery.columns.insert(0, "geo.country_code")

# Add region and country_code as fields
if not widgetQuery.fields:
widgetQuery.fields = []
if "geo.region" not in widgetQuery.fields:
widgetQuery.fields.insert(0, "geo.region")
if "geo.country_code" not in widgetQuery.fields:
widgetQuery.fields.insert(0, "geo.country_code")

widgetQuery.widget.save()
widgetQuery.save()


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production. For
# the most part, this should only be used for operations where it's safe to run the migration
# after your code has deployed. So this should not be used for most operations that alter the
# schema of a table.
# Here are some things that make sense to mark as dangerous:
# - Large data migrations. Typically we want these to be run manually by ops so that they can
# be monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# have ops run this and not block the deploy. Note that while adding an index is a schema
# change, it's completely safe to run the operation after the code has deployed.
is_dangerous = False

dependencies = [
("sentry", "0519_remove_repo_name_constraint"),
]

operations = [
migrations.RunPython(
migrate_worldmap_widgets_to_table_widgets,
migrations.RunPython.noop,
hints={"tables": ["sentry_dashboardwidgetquery", "sentry_dashboardwidget"]},
),
]
Loading