Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(crons): Reduce metric cardinality on monitor consumer #54296

Merged
merged 2 commits into from
Aug 8, 2023
Merged

ref(crons): Reduce metric cardinality on monitor consumer #54296

merged 2 commits into from
Aug 8, 2023

Conversation

rjo100
Copy link
Contributor

@rjo100 rjo100 commented Aug 7, 2023

Reduces metric cardinality on monitor consumer by stripping out version number & retaining only language + platform

@rjo100 rjo100 requested a review from a team as a code owner August 7, 2023 17:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #54296 (1a9e6e8) into master (7425c43) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #54296   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files        4985     4985           
  Lines      211367   211368    +1     
  Branches    36025    36025           
=======================================
+ Hits       168344   168346    +2     
  Misses      37847    37847           
+ Partials     5176     5175    -1
Files Changed Coverage Δ
src/sentry/monitors/consumers/monitor_consumer.py 88.10% <100.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

@rjo100 rjo100 mentioned this pull request Aug 7, 2023
Closed
@rjo100 rjo100 merged commit fa60cef into master Aug 8, 2023
56 checks passed
@rjo100 rjo100 deleted the rjo100/reduce-monitorconsumer-cardinality branch August 8, 2023 19:48
@rjo100 rjo100 added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Aug 8, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 2d71894

getsentry-bot added a commit that referenced this pull request Aug 8, 2023
@getsentry-bot @rjo100
Revert "ref(crons): Reduce metric cardinality on monitor consumer (#5…
2d71894 
…4296)"

This reverts commit fa60cef.

Co-authored-by: rjo100 <7078270+rjo100@users.noreply.github.com>
@rjo100 rjo100 removed the Trigger: Revert Add to a merged PR to revert it (skips CI) label Aug 8, 2023
rjo100 added a commit that referenced this pull request Aug 8, 2023
@rjo100
ref(crons): Reduce metric cardinality on monitor consumer (#54296)
71c96aa 
Reduces metric cardinality on monitor consumer by stripping out version
number & retaining only language + platform
@rjo100 rjo100 mentioned this pull request Aug 8, 2023
Merged
spalmurray pushed a commit that referenced this pull request Aug 8, 2023
@getsentry-bot @rjo100 @spalmurray-codecov
Revert "ref(crons): Reduce metric cardinality on monitor consumer (#5…
6ce0cc5 
…4296)"

This reverts commit fa60cef.

Co-authored-by: rjo100 <7078270+rjo100@users.noreply.github.com>
rjo100 added a commit that referenced this pull request Aug 9, 2023
@rjo100
ref(crons): Reduce metric cardinality on monitor consumer (#54296) (#…
9b8ff50 
…54411)

Re-do of #54296 which was
reverted mistakenly
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjo100 @getsentry-bot @evanpurkhiser