feat(sentryapps)-email-on-disable #54348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
reviewed
Aug 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54348 +/- ##
==========================================
- Coverage 79.66% 79.65% -0.01%
==========================================
Files 4985 4989 +4
Lines 211352 211498 +146
Branches 36026 36048 +22
==========================================
+ Hits 168373 168477 +104
- Misses 37800 37839 +39
- Partials 5179 5182 +3
|
chloeho7
changed the title
ceorourke
reviewed
Aug 8, 2023
ceorourke
reviewed
Aug 8, 2023
src/sentry/templates/sentry/integrations/sentry-app-notify-disable.html
Outdated
Show resolved
Hide resolved
ceorourke
reviewed
Aug 8, 2023
| <p> | ||
| Hi there, | ||
| </p><p> | ||
| We’ve received multiple <a href={{integration_link}}dashboard/>request errors</a> from your webhook: <a href={{webhook_url}}>{{webhook_url}}</a> for the custom {{ integration_name }} integration, and have unsubscribed the webhook from receiving events. |
There was a problem hiding this comment.
We might want to add a referrer to the URL for analytics and as this is set up, it'll be http://dev.getsentry.net:8000/settings/sentry/developer-settings/internal-35e455/?referrer=notify_disable_emaildashboard/ (missing the /). We could add the slash to the referrer query string but that seems odd, probably better to pass the dashboard URL to context.
ceorourke
approved these changes
Aug 8, 2023
spalmurray
pushed a commit
that referenced
this pull request
Aug 8, 2023
Implementing email notification when sentry app is detected to be broken and disabled. Part of [Notify on Disabled Integration project](https://www.notion.so/sentry/Tech-Spec-Notify-on-Disabled-Integration-Spec-e7ea0f86ccd6419cb3e564067cf4a2ef?pvs=4) Disabling and notifying implemented under feature flag "disable-sentryapps-on-broken". <img width="775" alt="Screenshot 2023-08-07 at 4 48 19 PM" src="https://github.com/getsentry/sentry/assets/56209417/e5edd998-7130-4c53-913b-ec9bb1e342bb">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing email notification when sentry app is detected to be broken and disabled.
Part of Notify on Disabled Integration project
Disabling and notifying implemented under feature flag "disable-sentryapps-on-broken".