Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metric-extraction): improve is on-demand metric check #54360

Merged
merged 4 commits into from
Aug 8, 2023
Merged

fix(metric-extraction): improve is on-demand metric check #54360

merged 4 commits into from
Aug 8, 2023

Conversation

obostjancic
Copy link
Member

@obostjancic obostjancic commented Aug 8, 2023 •
edited
Loading

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #54360 (c0d2008) into master (cac31d6) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 74.19%.

❗ Current head c0d2008 differs from pull request most recent head 981f354. Consider uploading reports for the commit 981f354 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #54360   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files        4986     4986           
  Lines      211350   211359    +9     
  Branches    36032    36035    +3     
=======================================
+ Hits       168332   168340    +8     
- Misses      37833    37835    +2     
+ Partials     5185     5184    -1
Files Changed Coverage Δ
src/sentry/relay/config/metric_extraction.py 88.05% <25.00%> (-4.25%) ⬇️
src/sentry/snuba/metrics/extraction.py 92.61% <91.30%> (+0.46%) ⬆️

... and 3 files with indirect coverage changes

@obostjancic obostjancic marked this pull request as ready for review August 8, 2023 11:36
@obostjancic obostjancic requested a review from a team August 8, 2023 11:36
@obostjancic obostjancic requested review from a team as code owners August 8, 2023 11:36
@obostjancic obostjancic assigned jan-auer and obostjancic and unassigned jan-auer Aug 8, 2023
iambriccardo
iambriccardo approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM.

In follow up PRs we should add support for NOT IN and IN.

src/sentry/snuba/metrics/extraction.py Outdated
if function not in _SEARCH_TO_METRIC_AGGREGATES.keys():
return False
# count() has no arguments
if len(arguments) == 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you check the function?

@obostjancic obostjancic enabled auto-merge (squash) August 8, 2023 12:56
@obostjancic obostjancic merged commit 0490995 into master Aug 8, 2023
55 checks passed
@obostjancic obostjancic deleted the ogi/fix/on-demand-extraction-errors branch August 8, 2023 13:25
@sentry-io
Copy link

sentry-io bot commented Aug 8, 2023

Suspect Issues

This pull request has been deployed and Sentry observed the following issues:

  • ‼️ IndexError: list index out of range sentry.tasks.relay.invalidate_project_config View Issue

Did you find this useful? React with a 👍 or 👎

@obostjancic obostjancic added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Aug 8, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 7e75367

getsentry-bot added a commit that referenced this pull request Aug 8, 2023
@getsentry-bot @obostjancic
Revert "fix(metric-extraction): improve is on-demand metric check (#5…
7e75367 
…4360)"

This reverts commit 0490995.

Co-authored-by: obostjancic <86684834+obostjancic@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

@RaduW RaduW RaduW approved these changes

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees

@obostjancic obostjancic

Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard on-demand metrics extraction errors
5 participants
@obostjancic @getsentry-bot @RaduW @iambriccardo @jan-auer