Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(on-demand): Improve query builder integration #54446

Merged
merged 9 commits into from
Aug 10, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Aug 9, 2023

This PR fixes an issue introduced in #54441.

@iambriccardo iambriccardo requested a review from a team as a code owner August 9, 2023 12:04
@iambriccardo iambriccardo requested a review from a team August 9, 2023 12:04
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #54446 (c04d377) into master (cac31d6) will increase coverage by 0.01%.
Report is 59 commits behind head on master.
The diff coverage is 86.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54446      +/-   ##
==========================================
+ Coverage   79.64%   79.66%   +0.01%     
==========================================
  Files        4986     4989       +3     
  Lines      211350   211590     +240     
  Branches    36032    36067      +35     
==========================================
+ Hits       168332   168556     +224     
- Misses      37833    37841       +8     
- Partials     5185     5193       +8     
Files Changed Coverage Δ
src/sentry/search/events/builder/metrics.py 81.77% <85.41%> (-0.71%) ⬇️
src/sentry/incidents/serializers/alert_rule.py 90.09% <100.00%> (ø)
src/sentry/search/events/builder/discover.py 91.88% <100.00%> (+0.02%) ⬆️

... and 125 files with indirect coverage changes

@iambriccardo iambriccardo merged commit f475e1b into master Aug 10, 2023
56 of 57 checks passed
@iambriccardo iambriccardo deleted the riccardo/ref/query-builder-on-demand branch August 10, 2023 07:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants