Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Add thresholds to monitor config (#54516) #54606

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

rjo100
Copy link
Contributor

@rjo100 rjo100 commented Aug 10, 2023

Unreverts #54516 as #54602 will fix errors

Adds `failure_issue_threshold` for value to create issues and
`recovery_threshold` for value to resolve issues.
@rjo100 rjo100 requested a review from a team as a code owner August 10, 2023 22:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #54606 (6004d17) into master (0b81521) will increase coverage by 2.25%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54606      +/-   ##
==========================================
+ Coverage   77.49%   79.74%   +2.25%     
==========================================
  Files        4995     4995              
  Lines      212238   212240       +2     
  Branches    36184    36184              
==========================================
+ Hits       164467   169253    +4786     
+ Misses      42486    37776    -4710     
+ Partials     5285     5211      -74     
Files Changed Coverage Δ
src/sentry/monitors/models.py 92.35% <ø> (+5.73%) ⬆️
src/sentry/monitors/validators.py 91.42% <100.00%> (+16.06%) ⬆️

... and 313 files with indirect coverage changes

@rjo100 rjo100 merged commit 9329640 into master Aug 11, 2023
56 of 57 checks passed
@rjo100 rjo100 deleted the rjo100/unrevert-monitor-config branch August 11, 2023 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants