chore(github): add open PR comments toggle and org option #54706
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
| disabled: | ||
| !hasIntegration || | ||
| !organization.features.includes('integrations-open-pr-comment'), |
There was a problem hiding this comment.
instead of checking for the feature here, you can add another field to this blob like this
visible: ({features}) => features.has('integrations-open-pr-comment')this hides the toggle entirely if the org doesn't have the feature flag
then you can pass features into the JsonForm
<JsonForm features={organization.features} forms={forms} />| @@ -137,6 +137,12 @@ | |||
| bool, | |||
| org_serializers.GITHUB_PR_BOT_DEFAULT, | |||
| ), | |||
| ( | |||
| "githubOpenPRComments", | |||
There was a problem hiding this comment.
hmm i feel like this name is pretty lengthy. maybe githubOpenPRBot would be better?
| let openPRDisabledReason = t( | ||
| 'You must have a GitHub integration to enable this feature.' | ||
| ); | ||
| if (!organization.features.includes('integrations-open-pr-comment')) { | ||
| openPRDisabledReason = t("This feature isn't available to you yet."); | ||
| } |
There was a problem hiding this comment.
if you hide the toggle when the org doesn't have the feature flag you won't need this extra reason
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54706 +/- ##
==========================================
+ Coverage 79.77% 79.78% +0.01%
==========================================
Files 5001 5000 -1
Lines 212264 212247 -17
Branches 36172 36159 -13
==========================================
+ Hits 169327 169336 +9
+ Misses 37721 37703 -18
+ Partials 5216 5208 -8
|
Add a toggle for open PR comments.