Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hc): Split db tests with new overrides #54754

Closed

Conversation

dashed
Copy link
Member

@dashed dashed commented Aug 15, 2023

Run split db tests with new overrides: get_from_cache() and get_many_from_cache().

@dashed dashed added the Trigger: Silo db Trigger tests with split databases that simulate hybrid cloud data separation in postgres label Aug 15, 2023
@dashed dashed self-assigned this Aug 15, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #54754 (ad3bf32) into master (425e95f) will decrease coverage by 0.08%.
Report is 11 commits behind head on master.
The diff coverage is 34.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54754      +/-   ##
==========================================
- Coverage   79.84%   79.76%   -0.08%     
==========================================
  Files        5019     5019              
  Lines      213419   213548     +129     
  Branches    36331    36336       +5     
==========================================
- Hits       170396   170341      -55     
- Misses      37781    37971     +190     
+ Partials     5242     5236       -6     
Files Changed Coverage Δ
src/sentry/db/models/manager/base.py 76.25% <ø> (ø)
.../issueDetails/groupReplays/useReplaysFromIssue.tsx 100.00% <ø> (ø)
...y/transactionReplays/useReplaysFromTransaction.tsx 84.21% <ø> (ø)
src/sentry/testutils/helpers/backups.py 35.89% <33.59%> (-61.12%) ⬇️
src/sentry/incidents/models.py 97.61% <100.00%> (+<0.01%) ⬆️

... and 19 files with indirect coverage changes

@dashed dashed force-pushed the hybrid-cloud/split-db/2-override-cache-methods-test branch from d322bc8 to ad3bf32 Compare August 16, 2023 17:42
@dashed dashed closed this Aug 16, 2023
@dashed dashed deleted the hybrid-cloud/split-db/2-override-cache-methods-test branch August 16, 2023 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Silo db Trigger tests with split databases that simulate hybrid cloud data separation in postgres
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant