feat(commit-context): Do not create if older than 1 year old #54866
Conversation
github-actions
bot
added
the
Scope: Backend
| committed_date = datetime.strptime( | ||
| commitInfo.get("committed_date"), date_format_expected | ||
| ).astimezone(timezone.utc) |
There was a problem hiding this comment.
this is sad that we have to define the format for 8601. Can we put a comment to replace this when we get to python 3.11 and can use dateutil.parser.isoparse
There was a problem hiding this comment.
added the comment!
There was a problem hiding this comment.
there is isodate.parse_date but we don't seem to use it anywhere
There was a problem hiding this comment.
hmm can you link to it?
There was a problem hiding this comment.
There was a problem hiding this comment.
refactored to use isodate.parse_datetime
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54866 +/- ##
==========================================
+ Coverage 79.74% 79.86% +0.11%
==========================================
Files 4995 5025 +30
Lines 212230 213885 +1655
Branches 36179 36393 +214
==========================================
+ Hits 169247 170813 +1566
- Misses 37775 37833 +58
- Partials 5208 5239 +31
|
NisanthanNanthakumar
deleted the
do-not-create-suspect-commits-older-than-1-year-old
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
asottile-sentry
added
the
Trigger: Revert
|
PR reverted: 245bce9 |
|
@NisanthanNanthakumar please write a test for this. this has now been reverted twice and the codecov integration has pointed out that this change is not covered by tests |
…55013) ## Objective: Update on the reverted PR: #54866 Fixes SENTRY-14ZG The problem was the wrong key. copy-paste error. But I noticed from the captured exceptions that some of the results from the github API does not return a date for the commit. So I added a filter for to exclude those commits from the `max` function that determines the most recent commit. --------- Co-authored-by: Snigdha Sharma <snigdha.sharma@sentry.io> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Objective
Update on the reverted PR: #54624
The original PR had errors from GitLab date strings not being parsed correctly bc they are formatted differently from GitHub. So this PR returns the datetime object for internal usage and will make date comparisons easier without needing to know which integration it came from.