Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(getting-started-docs): Source SDK version from sentry release registry #54943

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Aug 17, 2023

We're getting the SDK version from the sentry release registry and showing it for platforms that suggest a specific version for users to install.

It will be quite fast, but if the endpoint takes a bit longer to respond, a small '...loading' text will appear instead of a version number. During this time, users can't manually copy the code, and the button to copy it to the clipboard won't show up.

closes: #53921

Preview:

Screen.Recording.2023-08-17.at.14.57.14.mov

Requires #55018

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 17, 2023
@ArthurKnaus ArthurKnaus changed the title Priscila/feat/getting started docs source sdk version from sentry release registry draft feat(getting-started-docs): Source SDK version from sentry release registry Aug 18, 2023
@ArthurKnaus
Copy link
Member

The majority of the code was already reviewed in #54675
For the difference check my commits.
Changes:

  • Load release repository info from /api/0/[org-slug]/sdks/
  • Fixed a bug where the registry data was not properly forwarded to the spring-boot docs generator

@ArthurKnaus ArthurKnaus requested a review from a team August 18, 2023 09:55
@ArthurKnaus ArthurKnaus marked this pull request as ready for review August 18, 2023 09:55
@ArthurKnaus ArthurKnaus requested a review from a team as a code owner August 18, 2023 09:55
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll verify the functionality with preview deployment once the backend change is in place and we're good to go 👍

@matejminar matejminar merged commit 6f0ca6d into master Aug 18, 2023
50 checks passed
@matejminar matejminar deleted the priscila/feat/getting-started-docs-source-sdk-version-from-sentry-release-registry-draft branch August 18, 2023 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] Source SDK versions from release registry
4 participants