-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(getting-started-docs): Source SDK version from sentry release registry #54943
Merged
matejminar
merged 27 commits into
master
from
priscila/feat/getting-started-docs-source-sdk-version-from-sentry-release-registry-draft
Aug 18, 2023
Merged
feat(getting-started-docs): Source SDK version from sentry release registry #54943
matejminar
merged 27 commits into
master
from
priscila/feat/getting-started-docs-source-sdk-version-from-sentry-release-registry-draft
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Aug 17, 2023
…ng-started-docs-source-sdk-version-from-sentry-release-registry-draft
ArthurKnaus
changed the title
Priscila/feat/getting started docs source sdk version from sentry release registry draft
feat(getting-started-docs): Source SDK version from sentry release registry
Aug 18, 2023
The majority of the code was already reviewed in #54675
|
matejminar
reviewed
Aug 18, 2023
matejminar
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll verify the functionality with preview deployment once the backend change is in place and we're good to go 👍
matejminar
reviewed
Aug 18, 2023
static/app/components/onboarding/gettingStartedDoc/useSourcePackageRegistries.tsx
Outdated
Show resolved
Hide resolved
…ckageRegistries.tsx
obostjancic
approved these changes
Aug 18, 2023
matejminar
deleted the
priscila/feat/getting-started-docs-source-sdk-version-from-sentry-release-registry-draft
branch
August 18, 2023 12:58
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting the SDK version from the sentry release registry and showing it for platforms that suggest a specific version for users to install.
It will be quite fast, but if the endpoint takes a bit longer to respond, a small '...loading' text will appear instead of a version number. During this time, users can't manually copy the code, and the button to copy it to the clipboard won't show up.
closes: #53921
Preview:
Screen.Recording.2023-08-17.at.14.57.14.mov
Requires #55018