Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metrics.timer typo #55126

Closed
wants to merge 2 commits into from
Closed

fix: metrics.timer typo #55126

wants to merge 2 commits into from

Conversation

0o001
Copy link

@0o001 0o001 commented Aug 19, 2023

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@0o001 0o001 requested a review from a team as a code owner August 19, 2023 11:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 19, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #55126 (2286abf) into master (00fb8dd) will increase coverage by 1.86%.
Report is 582 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #55126      +/-   ##
==========================================
+ Coverage   79.11%   80.98%   +1.86%     
==========================================
  Files        5144     5165      +21     
  Lines      224118   240325   +16207     
  Branches    37741    42822    +5081     
==========================================
+ Hits       177305   194619   +17314     
+ Misses      41136    39901    -1235     
- Partials     5677     5805     +128     
Files Coverage Δ
src/sentry/incidents/tasks.py 81.03% <0.00%> (ø)

... and 419 files with indirect coverage changes

Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@armenzg armenzg added the Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests label Aug 21, 2023
@getsantry
Copy link
Contributor

getsantry bot commented Oct 19, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 19, 2023
@github-actions github-actions bot removed the Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests label Oct 19, 2023
@0o001
Copy link
Author

0o001 commented Oct 19, 2023

Anyone?

@getsantry getsantry bot closed this Oct 27, 2023
@0o001
Copy link
Author

0o001 commented Oct 27, 2023

@armenzg

@armenzg armenzg reopened this Nov 1, 2023
@armenzg armenzg enabled auto-merge (squash) November 1, 2023 14:13
@armenzg
Copy link
Member

armenzg commented Nov 1, 2023

My apologies. I don't know why I did not merge it right away. I've set the auto-merge so I don't forget.

Thanks @0o001 for the ping and your patience!

@getsantry getsantry bot closed this Nov 9, 2023
auto-merge was automatically disabled November 9, 2023 08:00

Pull request was closed

@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants