Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-alert-creation): Show detailed error text after attempting to send a test notification #55157

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

spalmurray
Copy link
Contributor

Previously, we would just show a generic message indicating the test notification failed.

This change shows the detailed form error text that was already showing on attempting to save the form.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 21, 2023
@spalmurray spalmurray marked this pull request as ready for review August 21, 2023 22:24
@spalmurray spalmurray requested a review from a team as a code owner August 21, 2023 22:24
@spalmurray spalmurray linked an issue Aug 21, 2023 that may be closed by this pull request
@17hogeju 17hogeju added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Sep 12, 2023
@17hogeju 17hogeju merged commit c40f020 into master Sep 13, 2023
45 of 46 checks passed
@17hogeju 17hogeju deleted the spalmurray/discord-issue-alert-form-error-state branch September 13, 2023 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants