Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discord): Handle case where issue does not exist #55161

Closed
wants to merge 3 commits into from

Conversation

spalmurray
Copy link
Contributor

  • Gracefully handle case where issue does not exist
  • Add message param to DiscordInteractionHandlerError
  • Add test

FIXES SENTRY-150T

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #55161 (57dfe5b) into master (2e10de6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #55161      +/-   ##
==========================================
- Coverage   79.95%   79.95%   -0.01%     
==========================================
  Files        5034     5034              
  Lines      214524   214539      +15     
  Branches    36439    36440       +1     
==========================================
+ Hits       171514   171525      +11     
- Misses      37743    37747       +4     
  Partials     5267     5267              
Files Changed Coverage Δ
src/sentry/integrations/discord/webhooks/base.py 100.00% <100.00%> (ø)
...rc/sentry/integrations/discord/webhooks/handler.py 100.00% <100.00%> (ø)
...integrations/discord/webhooks/message_component.py 98.38% <100.00%> (+0.05%) ⬆️

... and 5 files with indirect coverage changes

@getsantry getsantry bot added the Stale label Oct 19, 2023
@getsantry getsantry bot closed this Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants