Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(js): Convert PageOverlay to a FC #55168

Merged

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team August 22, 2023 02:58
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 22, 2023
@@ -1,4 +1,4 @@
import {Component, createRef} from 'react';
import React, {useEffect, useRef} from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importing react now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, I was testing soemthing

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-js-convert-pageoverlay-to-a-fc branch from 90bbbb4 to 6307db6 Compare August 30, 2023 17:27
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) August 30, 2023 17:30
@evanpurkhiser evanpurkhiser merged commit af2d0cd into master Aug 30, 2023
49 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-js-convert-pageoverlay-to-a-fc branch August 30, 2023 17:56
@JoshFerge JoshFerge added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Aug 30, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: deda491

getsentry-bot added a commit that referenced this pull request Aug 30, 2023
This reverts commit af2d0cd.

Co-authored-by: JoshFerge <1976777+JoshFerge@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants