Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry/utils/distutils: fix yarn invocation #55182

Closed
wants to merge 1 commit into from

Conversation

rockdrilla
Copy link

Yarn doesn't have --quiet flag and fails immediately when executed with such flag.
Tested with Yarn 1.22.19.

Legal Boilerplate

I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #55182 (5f36d39) into master (a34bfc2) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #55182   +/-   ##
=======================================
  Coverage   79.95%   79.95%           
=======================================
  Files        5034     5034           
  Lines      214524   214525    +1     
  Branches    36439    36439           
=======================================
+ Hits       171513   171521    +8     
  Misses      37740    37740           
+ Partials     5271     5264    -7     
Files Changed Coverage Δ
src/sentry/conf/server.py 91.85% <ø> (ø)
src/sentry/features/__init__.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Oct 19, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 19, 2023
@getsantry getsantry bot closed this Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant