fix(projects): Show join a team if person doesn't have a team #55499
Conversation
github-actions
bot
added
the
Scope: Frontend
| @@ -39,7 +40,10 @@ function NoProjectMessage({ | |||
| ? !!projects?.some(p => p.hasAccess) | |||
| : !!projects?.some(p => p.isMember && p.hasAccess); | |||
|
|
|||
| if (hasProjectAccess || !projectsLoaded || !teamsLoaded) { | |||
| if ( | |||
| (isTeamMember || isSuperuser) && | |||
There was a problem hiding this comment.
This is the only change from previous PR
| @@ -96,4 +132,22 @@ describe('NoProjectMessage', function () { | |||
| screen.getByText('You need at least one project to use this view') | |||
| ).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| it('shows projects to superusers if membership is not required', function () { | |||
There was a problem hiding this comment.
This is the test that would have failed on the previous PR
sentaur-athena
requested review from
maheskett and
cathteng
and removed request for
a team
|
Did you link the correct PR in your description? |
|
|
||
| it('shows projects to superusers if membership is not required', function () { | ||
| ProjectsStore.loadInitialData([ | ||
| TestStubs.Project({hasAccess: true, isMember: false}), |
There was a problem hiding this comment.
do we always return hasAccess: true for projects when you're superuser?
There was a problem hiding this comment.
No. The component I'm modifying has a prop superuserNeedsToBeProjectMember that if that is set they will only see projects that have access to. And if false they see all projects. This component is used in multiple places so that's why the prop exist. Let me remove the access field from the test to make it simpler since it doesn't matter.
|
@nhsiehgit you're right. I fixed it 😅 |
| @@ -96,4 +132,22 @@ describe('NoProjectMessage', function () { | |||
| screen.getByText('You need at least one project to use this view') | |||
| ).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| it('shows projects to superusers if membership is not required', function () { | |||
sentaur-athena
changed the title
sentaur-athena
added
the
Trigger: Revert
|
PR reverted: 8a10a85 |
This reverts commit e4f8f53. Co-authored-by: sentaur-athena <132939361+sentaur-athena@users.noreply.github.com>
|
This is breaking some other experience again. I'll go ahead and make another change only affecting fly people or something 😅 |
Exact copy of #55190 except this time considering that super users don't have teams and still might have project access.