fix(hybrid-cloud): Fix notification helpers for split db and split silo world #55829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mrduncan
approved these changes
Sep 7, 2023
Codecov Report
@@ Coverage Diff @@
## master #55829 +/- ##
==========================================
- Coverage 80.14% 80.14% -0.01%
==========================================
Files 5055 5055
Lines 217204 217204
Branches 36779 36779
==========================================
- Hits 174077 174070 -7
- Misses 37779 37785 +6
- Partials 5348 5349 +1
|
dashed
force-pushed
the
hybrid-cloud/split-silo-test/2-notification-helpers
branch
from
72b8782
to
a0f8ca8
Compare
dashed
force-pushed
the
hybrid-cloud/split-silo-test/2-notification-helpers
branch
from
a0f8ca8
to
a7330c6
Compare
dashed
force-pushed
the
hybrid-cloud/split-silo-test/2-notification-helpers
branch
from
a7330c6
to
a64560d
Compare
dashed
commented
Sep 7, 2023
| @@ -15,12 +15,11 @@ | |||
| "sentry.DeletedOrganization", | |||
| "sentry.Email", | |||
| "sentry.Organization", | |||
| "sentry.User", | |||
There was a problem hiding this comment.
This change in this PR reverts the change introduced in #55744.
GabeVillalobos
approved these changes
Sep 7, 2023
dashed
deleted the
hybrid-cloud/split-silo-test/2-notification-helpers
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification helpers can only be called from the region silo, and thus querying on the
Usermodel is not legal.