Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Implement envelope forwarding #55840

Merged
merged 40 commits into from
Sep 13, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Sep 7, 2023

This PR implements envelope forwarding with the following components:

  • Envelope forwarding via the capture_envelope
  • Envelope encoding via the RelayMetricEnvelopeEncoder

It also restructures types in their own file in order to avoid circular dependencies.

Closes #55658

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 7, 2023
@iambriccardo iambriccardo changed the base branch from master to riccardo/ref/refactor-minimetrics September 7, 2023 10:20
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #55840 (6a6e4a1) into master (3da7380) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #55840      +/-   ##
==========================================
- Coverage   79.98%   79.98%   -0.01%     
==========================================
  Files        5061     5061              
  Lines      217757   217760       +3     
  Branches    36862    36863       +1     
==========================================
+ Hits       174168   174169       +1     
- Misses      38244    38246       +2     
  Partials     5345     5345              
Files Changed Coverage
src/sentry/options/defaults.py 100.00%

Base automatically changed from riccardo/ref/refactor-minimetrics to master September 8, 2023 07:23
@iambriccardo iambriccardo changed the title riccardo/ref/emit envelope ref feat(metrics): Implement Sep 8, 2023
@iambriccardo iambriccardo changed the title feat(metrics): Implement feat(metrics): Implement envelope forwarding Sep 8, 2023
src/minimetrics/types.py Outdated Show resolved Hide resolved
src/minimetrics/core.py Outdated Show resolved Hide resolved
src/minimetrics/types.py Outdated Show resolved Hide resolved
src/minimetrics/transport.py Outdated Show resolved Hide resolved
src/minimetrics/core.py Show resolved Hide resolved
src/minimetrics/transport.py Outdated Show resolved Hide resolved
src/minimetrics/transport.py Outdated Show resolved Hide resolved
src/minimetrics/transport.py Outdated Show resolved Hide resolved
src/minimetrics/transport.py Outdated Show resolved Hide resolved
src/minimetrics/transport.py Show resolved Hide resolved
@iambriccardo iambriccardo merged commit 370b4ea into master Sep 13, 2023
52 checks passed
@iambriccardo iambriccardo deleted the riccardo/ref/emit-envelope-ref branch September 13, 2023 06:00
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch minimetrics SDK to Relay statsd protocol
2 participants