-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Implement envelope forwarding #55840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Sep 7, 2023
iambriccardo
changed the base branch from
master
to
riccardo/ref/refactor-minimetrics
September 7, 2023 10:20
Codecov Report
@@ Coverage Diff @@
## master #55840 +/- ##
==========================================
- Coverage 79.98% 79.98% -0.01%
==========================================
Files 5061 5061
Lines 217757 217760 +3
Branches 36862 36863 +1
==========================================
+ Hits 174168 174169 +1
- Misses 38244 38246 +2
Partials 5345 5345
|
iambriccardo
force-pushed
the
riccardo/ref/emit-envelope-ref
branch
from
September 8, 2023 07:45
19300df
to
69e7ffd
Compare
iambriccardo
changed the title
feat(metrics): Implement
feat(metrics): Implement envelope forwarding
Sep 8, 2023
jan-auer
reviewed
Sep 12, 2023
jan-auer
approved these changes
Sep 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements envelope forwarding with the following components:
capture_envelope
RelayMetricEnvelopeEncoder
It also restructures types in their own file in order to avoid circular dependencies.
Closes #55658