Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github-growth): add column for file language in CommitFileChange #55858

Merged

Conversation

cathteng
Copy link
Member

@cathteng cathteng commented Sep 7, 2023

Re-up of #55732 since it got reverted during an incident (it did not cause the incident). AKA a revert revert

@cathteng cathteng requested a review from a team September 7, 2023 17:41
@cathteng cathteng requested a review from a team as a code owner September 7, 2023 17:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 7, 2023
Copy link
Contributor

@mifu67 mifu67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

This PR has a migration; here is the generated SQL for src/sentry/migrations/0544_add_commitfilechange_language_col.py ()

--
-- Add field language to commitfilechange
--
ALTER TABLE "sentry_commitfilechange" ADD COLUMN "language" varchar(255) NULL;

@cathteng cathteng enabled auto-merge (squash) September 7, 2023 17:43
@cathteng cathteng merged commit e10d33d into master Sep 7, 2023
62 checks passed
@cathteng cathteng deleted the cathy/github-growth/commit-filechange-language-col-2 branch September 7, 2023 18:13
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #55858 (93dd0f1) into master (3645068) will decrease coverage by 1.59%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #55858      +/-   ##
==========================================
- Coverage   79.96%   78.37%   -1.59%     
==========================================
  Files        5055     5054       -1     
  Lines      217222   217173      -49     
  Branches    36784    36776       -8     
==========================================
- Hits       173701   170209    -3492     
- Misses      38189    41590    +3401     
- Partials     5332     5374      +42     
Files Changed Coverage
src/sentry/models/commitfilechange.py 100.00%

📢 Thoughts on this report? Let us know!.

@cathteng cathteng added the Trigger: Revert add to a merged PR to revert it (skips CI) label Sep 7, 2023
@getsentry-bot
Copy link
Contributor

revert failed (conflict? already reverted?) -- check the logs

@mattgauntseo-sentry mattgauntseo-sentry added Trigger: Revert add to a merged PR to revert it (skips CI) and removed Trigger: Revert add to a merged PR to revert it (skips CI) labels Sep 7, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: a642971

getsentry-bot added a commit that referenced this pull request Sep 7, 2023
…ileChange (#55858)"

This reverts commit e10d33d.

Co-authored-by: mattgauntseo-sentry <112419115+mattgauntseo-sentry@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants