Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations) Conditionally remove groupsubscription columns #55870

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

markstory
Copy link
Member

@markstory markstory commented Sep 7, 2023

Get us back to a state where we can add these fields again as environments are inconsistent currently.

Once this is out we'll be able to re-add the schema changes from 543

@markstory markstory requested a review from a team as a code owner September 7, 2023 19:24
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 7, 2023
Get us back to a state where we can add these fields again as
environments are inconsistent currently.

Once this is out we'll be able to re-add the schema changes from 543
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

This PR has a migration; here is the generated SQL for src/sentry/migrations/0545_remove_groupsubscription_columns.py ()

--
-- Custom state/database change combination
--

                    ALTER TABLE sentry_groupsubscription DROP CONSTRAINT IF EXISTS subscription_team_or_user_check;
                    ALTER TABLE sentry_groupsubscription DROP COLUMN IF EXISTS team_id;
                    ;

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #55870 (b16d3c0) into master (948f881) will decrease coverage by 0.03%.
Report is 10 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #55870      +/-   ##
==========================================
- Coverage   79.95%   79.93%   -0.03%     
==========================================
  Files        5057     5060       +3     
  Lines      217281   217421     +140     
  Branches    36785    36796      +11     
==========================================
+ Hits       173725   173787      +62     
- Misses      38230    38302      +72     
- Partials     5326     5332       +6     
Files Changed Coverage
src/sentry/api/endpoints/project_rule_details.py ø
src/sentry/api/endpoints/project_rules.py ø
src/sentry/models/groupsubscription.py 100.00%

📢 Thoughts on this report? Let us know!.

@markstory markstory merged commit 761041e into master Sep 7, 2023
59 checks passed
@markstory markstory deleted the fix-groupsub-migration branch September 7, 2023 20:55
@mattgauntseo-sentry mattgauntseo-sentry added the Trigger: Revert add to a merged PR to revert it (skips CI) label Sep 7, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 03285f6

getsentry-bot added a commit that referenced this pull request Sep 7, 2023
#55870)"

This reverts commit 761041e.

Co-authored-by: mattgauntseo-sentry <112419115+mattgauntseo-sentry@users.noreply.github.com>
@mattgauntseo-sentry mattgauntseo-sentry restored the fix-groupsub-migration branch September 7, 2023 23:23
roggenkemper added a commit that referenced this pull request Sep 12, 2023
this pr adds back the addition of team as a field on GroupSubscription
(originally from #55805 ,
removed in #55870) .
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants