feat(team-workflow): Update `bulk_subscribe` to accept teams #55943

isabellaenriquez · 2023-09-08T20:55:39Z

This PR updates bulk_subscribe so that it can accept both teams and user IDs (or either).

~~❗ BLOCKED BY #55879 and #55825~~

codecov · 2023-09-08T21:26:32Z

Codecov Report

Merging #55943 (134febc) into master (c2f0c36) will decrease coverage by 0.01%.
Report is 11 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #55943      +/-   ##
==========================================
- Coverage   80.00%   80.00%   -0.01%     
==========================================
  Files        5066     5066              
  Lines      217914   217967      +53     
  Branches    36880    36885       +5     
==========================================
+ Hits       174337   174377      +40     
- Misses      38229    38243      +14     
+ Partials     5348     5347       -1

Files Changed	Coverage
...atic/app/utils/analytics/growthAnalyticsEvents.tsx	`ø`
.../views/settings/projectDebugFiles/debugFileRow.tsx	`ø`
...tic/app/views/settings/projectDebugFiles/index.tsx	`ø`
.../projectDebugFiles/sources/builtInRepositories.tsx	`ø`
...ectDebugFiles/sources/customRepositories/index.tsx	`ø`
...views/settings/projectDebugFiles/sources/index.tsx	`ø`
src/sentry/api/endpoints/debug_files.py	`100.00%`
src/sentry/models/groupsubscription.py	`100.00%`
src/sentry/notifications/notifications/digest.py	`100.00%`
src/sentry/notifications/notifications/rules.py	`100.00%`

…tests

src/sentry/models/groupsubscription.py

tests/sentry/models/test_groupsubscription.py

snigdhas · 2023-09-13T17:19:31Z

tests/sentry/models/test_groupsubscription.py

+
+ def test_bulk_user_on_team(self):
+ """
+ Test that ensures bulk_subscribe subscribes users and teams individually, even if one of those users is part of one of those teams.


great comment!

src/sentry/models/groupsubscription.py

roggenkemper

lgtm , but let's get one more approval before we merge

modify bulk_subscribe to accept teams

9ac7375

isabellaenriquez self-assigned this Sep 8, 2023

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 8, 2023

Update call to bulk_subscribe

8daee5c

vercel bot deployed to Preview September 11, 2023 19:05 View deployment

correct typo + set default args and account for Nones + correct some …

ba96c7f

…tests

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview September 11, 2023 19:16 View deployment

Merge branch 'master' into isabellaenriquez/bulk-subscribe-teams

44c1dde

vercel bot deployed to Preview September 12, 2023 18:35 View deployment

Fix tests

35e19bf

vercel bot deployed to Preview September 12, 2023 18:53 View deployment

isabellaenriquez marked this pull request as ready for review September 12, 2023 19:55

isabellaenriquez requested a review from a team September 12, 2023 19:55

JoshFerge reviewed Sep 12, 2023

View reviewed changes

src/sentry/models/groupsubscription.py Outdated Show resolved Hide resolved

Merge branch 'master' into isabellaenriquez/bulk-subscribe-teams

2eb30d9

vercel bot deployed to Preview September 13, 2023 16:37 View deployment

snigdhas reviewed Sep 13, 2023

View reviewed changes

src/sentry/models/groupsubscription.py Outdated Show resolved Hide resolved

snigdhas reviewed Sep 13, 2023

View reviewed changes

src/sentry/models/groupsubscription.py Outdated Show resolved Hide resolved

snigdhas reviewed Sep 13, 2023

View reviewed changes

tests/sentry/models/test_groupsubscription.py Outdated Show resolved Hide resolved

snigdhas reviewed Sep 13, 2023

View reviewed changes

src/sentry/models/groupsubscription.py Outdated Show resolved Hide resolved

Address PR feedback

a0fd5f2

vercel bot deployed to Preview September 13, 2023 17:26 View deployment

Change bulk_subscribe to take team_ids instead of teams

9eeb4bb

isabellaenriquez requested a review from snigdhas September 13, 2023 17:48

vercel bot deployed to Preview September 13, 2023 17:50 View deployment

Merge branch 'master' into isabellaenriquez/bulk-subscribe-teams

186610a

vercel bot deployed to Preview September 13, 2023 18:07 View deployment

roggenkemper reviewed Sep 13, 2023

View reviewed changes

src/sentry/models/groupsubscription.py Outdated Show resolved Hide resolved

add feature flag to bulk_subscribe

134febc

vercel bot deployed to Preview September 13, 2023 18:54 View deployment

roggenkemper approved these changes Sep 13, 2023

View reviewed changes

snigdhas approved these changes Sep 13, 2023

View reviewed changes

isabellaenriquez merged commit 6f77d14 into master Sep 13, 2023
53 checks passed

isabellaenriquez deleted the isabellaenriquez/bulk-subscribe-teams branch September 13, 2023 21:09

github-actions bot locked and limited conversation to collaborators Sep 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(team-workflow): Update `bulk_subscribe` to accept teams #55943

feat(team-workflow): Update `bulk_subscribe` to accept teams #55943

isabellaenriquez commented Sep 8, 2023 •

edited

Loading

codecov bot commented Sep 8, 2023 •

edited

Loading

This comment was marked as outdated.

snigdhas Sep 13, 2023

roggenkemper left a comment

feat(team-workflow): Update bulk_subscribe to accept teams #55943

feat(team-workflow): Update bulk_subscribe to accept teams #55943

Conversation

isabellaenriquez commented Sep 8, 2023 • edited Loading

codecov bot commented Sep 8, 2023 • edited Loading

Codecov Report

This comment was marked as outdated.

snigdhas Sep 13, 2023

Choose a reason for hiding this comment

roggenkemper left a comment

Choose a reason for hiding this comment

feat(team-workflow): Update `bulk_subscribe` to accept teams #55943

feat(team-workflow): Update `bulk_subscribe` to accept teams #55943

isabellaenriquez commented Sep 8, 2023 •

edited

Loading

codecov bot commented Sep 8, 2023 •

edited

Loading