feat: Add notification_uuid to digest URLs #55951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #55951 +/- ##
==========================================
- Coverage 80.00% 80.00% -0.01%
==========================================
Files 5066 5066
Lines 217936 217949 +13
Branches 36881 36884 +3
==========================================
+ Hits 174356 174365 +9
- Misses 38233 38235 +2
- Partials 5347 5349 +2
|
scttcper
approved these changes
Sep 11, 2023
# Conflicts: # tests/sentry/notifications/notifications/test_digests.py
# Conflicts: # tests/sentry/notifications/notifications/test_digests.py
|
PR reverted: 6477a19 |
getsentry-bot
added a commit
that referenced
this pull request
Sep 13, 2023
This reverts commit 2a46053. Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
armenzg
reviewed
Sep 14, 2023
| @@ -42,7 +43,7 @@ def schedule_digests(): | |||
| queue="digests.delivery", | |||
| silo_mode=SiloMode.REGION, | |||
| ) | |||
| def deliver_digest(key, schedule_timestamp=None): | |||
| def deliver_digest(key, schedule_timestamp=None, notification_uuid: Optional[str] = None): | |||
There was a problem hiding this comment.
You may want an interim PR to use kwargs and then swap to a explicit variable.
There was a problem hiding this comment.
I'm told that this may be a 3 way rollout:
(1) add new optional parameter
(2) start sending new parameter
(3) remove optional-ness
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notification_uuid to digest links
closes #54415