feat(notifications): Refactor helpers for notification reads #56064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #56064 +/- ##
==========================================
+ Coverage 79.95% 79.98% +0.03%
==========================================
Files 5060 5062 +2
Lines 217590 217752 +162
Branches 36838 36853 +15
==========================================
+ Hits 173976 174173 +197
+ Misses 38285 38235 -50
- Partials 5329 5344 +15
|
JoshFerge
reviewed
Sep 12, 2023
scttcper
approved these changes
Sep 12, 2023
markstory
reviewed
Sep 13, 2023
| return notification_settings | ||
| def get_recipient_from_team_or_user(user_id: int | None, team_id: int | None) -> RpcUser | Team: | ||
| if user_id is not None: | ||
| recipient = RpcUser(id=user_id) |
There was a problem hiding this comment.
Does this recipient get any of its other attributes used? You can use user_service.get_user() to fetch the hydrated user record.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also support querying multiple projects and use RpcUsers for silo code.
This takes changes from #55855 and #55898 which I'll close.