Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feedback): add organization feedback index GET endpoint #56065

Merged
merged 20 commits into from
Sep 13, 2023
Merged

feat(feedback): add organization feedback index GET endpoint #56065

merged 20 commits into from
Sep 13, 2023

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Sep 12, 2023 •
edited
Loading

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #56065 (57228f7) into master (6b22ef0) will decrease coverage by 1.68%.
Report is 98 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #56065      +/-   ##
==========================================
- Coverage   79.98%   78.31%   -1.68%     
==========================================
  Files        5061     5066       +5     
  Lines      217743   217910     +167     
  Branches    36861    36875      +14     
==========================================
- Hits       174159   170648    -3511     
- Misses      38237    41855    +3618     
- Partials     5347     5407      +60
Files Changed Coverage
src/sentry/feedback/migrations/0001_feedback.py ø
src/sentry/api/urls.py 100.00%
src/sentry/feedback/endpoints/feedback_ingest.py 100.00%
.../feedback/endpoints/organization_feedback_index.py 100.00%
src/sentry/feedback/models.py 100.00%
src/sentry/feedback/serializers.py 100.00%

@michellewzhang michellewzhang marked this pull request as ready for review September 12, 2023 23:13
@michellewzhang michellewzhang requested review from a team as code owners September 12, 2023 23:13
JoshFerge
JoshFerge reviewed Sep 13, 2023
View reviewed changes
src/sentry/feedback/endpoints/feedback_ingest.py
Comment on lines +69 to +70
"browser": data.get("BrowserContext"),
"device": data.get("DeviceContext"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add a shim in future PR for these fields

@michellewzhang michellewzhang merged commit 759d83a into master Sep 13, 2023
52 checks passed
@michellewzhang michellewzhang deleted the mz/get branch September 13, 2023 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshFerge JoshFerge JoshFerge approved these changes

@billyvg billyvg Awaiting requested review from billyvg

@cmanallen cmanallen Awaiting requested review from cmanallen

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michellewzhang @JoshFerge