fix(UI): Let team admin add built-in/custom repos + delete debug files #56123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
schew2381
changed the title
sentaur-athena
approved these changes
Sep 12, 2023
github-actions
bot
added
the
Scope: Backend
schew2381
force-pushed
the
seiji/fix/let-team-admins-upload-debug-files
branch
from
ad37533
to
eee29e5
Compare
schew2381
removed
Do Not Merge
schew2381
changed the title
schew2381
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #56148 - backend changes to let team admins delete debug files
In order to check the write access for Team Admins, I need the full project. Originally we were drilling down the project slug instead of the project itself, so I changed it to pass the full project for built-in + custom repo components
Recording of a Team Admin (unable to delete debug file because backend changes are in other PR)
Screen.Recording.2023-09-12.at.6.56.55.PM.mov
Fixes #56116 and #53919