Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: fix 'base class ... defined the type as None mypy errors #56124

Merged
merged 1 commit into from
Sep 13, 2023
Merged

ref: fix 'base class ... defined the type as None mypy errors #56124

merged 1 commit into from
Sep 13, 2023

Conversation

asottile-sentry
Copy link
Member

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #56124 (a74f6fe) into master (0561163) will increase coverage by 0.00%.
The diff coverage is 94.28%.

@@           Coverage Diff           @@
##           master   #56124   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files        5062     5062           
  Lines      217730   217740   +10     
  Branches    36856    36856           
=======================================
+ Hits       174174   174187   +13     
+ Misses      38208    38207    -1     
+ Partials     5348     5346    -2
Files Changed Coverage
src/sentry/auth/providers/github/provider.py 50.00%
src/sentry/auth/providers/oauth2.py 100.00%
src/sentry/integrations/mixins/issues.py 100.00%
src/sentry/mail/forms/assigned_to.py 100.00%
src/sentry/mail/forms/member_team.py 100.00%
src/sentry/mail/forms/notify_email.py 100.00%
src/sentry/plugins/bases/tag.py 100.00%
...sentry/plugins/providers/integration_repository.py 100.00%
src/sentry/plugins/providers/repository.py 100.00%
src/sentry/tagstore/types.py 100.00%

@asottile-sentry asottile-sentry force-pushed the asottile-base-class-defined-as-none branch from 5bd6886 to a74f6fe Compare September 13, 2023 13:49
@asottile-sentry asottile-sentry marked this pull request as ready for review September 13, 2023 14:22
@asottile-sentry asottile-sentry requested review from a team September 13, 2023 14:22
@asottile-sentry asottile-sentry merged commit cf29f5e into master Sep 13, 2023
53 checks passed
@asottile-sentry asottile-sentry deleted the asottile-base-class-defined-as-none branch September 13, 2023 18:22
@asottile-sentry asottile-sentry added the Trigger: Revert add to a merged PR to revert it (skips CI) label Sep 13, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 8bb4bd9

getsentry-bot added a commit that referenced this pull request Sep 13, 2023
@getsentry-bot @asottile-sentry
Revert "ref: fix 'base class ... defined the type as None mypy errors (…
8bb4bd9 
…#56124)"

This reverts commit cf29f5e.

Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
@asottile-sentry
Copy link
Member Author

https://sentry.sentry.io/issues/4475641944/?project=1&query=firstRelease%3Abackend%403e5c798ce4407ae19429341a481cc4a8339dac73&referrer=issue-stream&stream_index=0

missed a call in some uncovered code

asottile-sentry added a commit that referenced this pull request Sep 13, 2023
@asottile-sentry
Revert "Revert "ref: fix 'base class ... defined the type as None myp…
9fde136 
…y errors (#56124)""

This reverts commit 8bb4bd9.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshFerge JoshFerge JoshFerge approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asottile-sentry @getsentry-bot @JoshFerge