Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(statistical-detectors): Unify breakpoint detection interface #56324

Merged
merged 1 commit into from
Sep 15, 2023
Merged

ref(statistical-detectors): Unify breakpoint detection interface #56324

merged 1 commit into from
Sep 15, 2023

Conversation

Zylphrex
Copy link
Member

There's no reason to keep multiple connection pools to the breakpoint service. Especially as statistical detectors will use it now as well.

@Zylphrex
ref(statistical-detectors): Unify breakpoint detection interface
7da1663 
There's no reason to keep multiple connection pools to the breakpoint service.
Especially as statistical detectors will use it now as well.
@Zylphrex Zylphrex requested a review from a team as a code owner September 15, 2023 14:27
@Zylphrex Zylphrex requested a review from a team September 15, 2023 14:27
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #56324 (7da1663) into master (952f171) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 84.61%.

@@           Coverage Diff           @@
##           master   #56324   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files        5070     5071    +1     
  Lines      217976   217971    -5     
  Branches    36896    36896           
=======================================
- Hits       171489   171488    -1     
+ Misses      40949    40945    -4     
  Partials     5538     5538
Files Changed Coverage
src/sentry/seer/utils.py 75.00%
...try/api/endpoints/organization_events_trends_v2.py 100.00%
.../api/endpoints/organization_profiling_functions.py 100.00%

@Zylphrex Zylphrex enabled auto-merge (squash) September 15, 2023 14:57
@Zylphrex Zylphrex merged commit 6a18a6d into master Sep 15, 2023
51 of 52 checks passed
@Zylphrex Zylphrex deleted the txiao/ref/unify-breakpoint-detection-interface branch September 15, 2023 14:57
@Zylphrex Zylphrex added the Trigger: Revert add to a merged PR to revert it (skips CI) label Sep 15, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: a5d0e77

getsentry-bot added a commit that referenced this pull request Sep 15, 2023
@getsentry-bot @Zylphrex
Revert "ref(statistical-detectors): Unify breakpoint detection interf…
a5d0e77 
…ace (#56324)"

This reverts commit 6a18a6d.

Co-authored-by: Zylphrex <10239353+Zylphrex@users.noreply.github.com>
@Zylphrex Zylphrex mentioned this pull request Sep 15, 2023
Merged
Zylphrex added a commit that referenced this pull request Sep 15, 2023
@Zylphrex
ref(statistical-detectors): Unify breakpoint detection interface (#56332
ba4cba4 
)

There's no reason to keep multiple connection pools to the breakpoint
service. Especially as statistical detectors will use it now as well.


There was a bug in #56324 where performance used the raw payload whereas
profiling returned only the `"data"` key.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@udameli udameli udameli approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zylphrex @getsentry-bot @udameli