ref(hc): Do not run default project setup for non self hosted cases. #56489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #56489 +/- ##
==========================================
- Coverage 78.64% 78.64% -0.01%
==========================================
Files 5078 5078
Lines 218267 218270 +3
Branches 36952 36953 +1
==========================================
+ Hits 171654 171656 +2
- Misses 41072 41075 +3
+ Partials 5541 5539 -2
|
mrduncan
approved these changes
Sep 19, 2023
|
PR reverted: 435fbde |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% sure if this is the correct change, looking for feedback.
Obviously running create default projects for self hosted on
sentry upgrademakes sense. And obviously we should not do so for S4S (see inc-510). But is S4S considered self hosted? And what about ST?Looking for insight from someone who fully understands our sentry deployments.