feat(save_event): Always use cache for stacktrace processing #56535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We enabled it for EA customers last week without any issues. It reduces the stacktrace normalization by 40%.
github-actions
bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #56535 +/- ##
==========================================
+ Coverage 78.59% 78.60% +0.01%
==========================================
Files 5081 5081
Lines 218745 218742 -3
Branches 37047 37047
==========================================
+ Hits 171927 171947 +20
+ Misses 41251 41231 -20
+ Partials 5567 5564 -3
|
brianthi
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enabled it for EA customers last week without any issues. It reduces the stacktrace normalization by 40%. It's most noticeable with Native events.
A repeat of #56413 which got reverted by mistake.