chore(api): Delete acceptance test for user tokens #56537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56537 +/- ##
=======================================
Coverage 78.59% 78.60%
=======================================
Files 5081 5081
Lines 218745 218745
Branches 37047 37047
=======================================
+ Hits 171927 171942 +15
+ Misses 41251 41239 -12
+ Partials 5567 5564 -3 |
cathteng
approved these changes
Sep 20, 2023
schew2381
deleted the
seiji/chore/delete-acceptance-test-in-separate-pr
branch
schew2381
added a commit
that referenced
this pull request
Sep 21, 2023
Requires #56537 ### Summary Refactor the create user token page to use existing dropdowns (like [org/integration tokens page](https://santry.sentry.io/settings/developer-settings/new-internal/)). This enforces hierarchy automatically when creating user tokens through the UI. ### Scopes Originally you could select scopes granularly, so you could check `project:admin` but not `project:read`. The dropdowns will include all weaker scopes for the same resource you're selecting. Ideally we would call each option in the dropdown: ```mdx Ideal Current - read - read - write vs. - read + write - admin - admin Note: Admin implies access to everything so includes read + write + any other special scope for that resource e.g. project:releases/org:integrations ``` and explain the hierarchy in the header description with a link to our scope docs. However we still need to overhaul our scope docs so this change will have to come after the docs are complete. ### Before <img width="1267" alt="Screenshot 2023-08-11 at 3 15 13 PM" src="https://github.com/getsentry/sentry/assets/67301797/9e590eff-f839-4678-ab55-ac41610fdc8a"> ### After https://github.com/getsentry/sentry/assets/67301797/f0c1c730-ad51-4977-8b0c-0b026cf3d8b4
michellewzhang
pushed a commit
that referenced
this pull request
Sep 21, 2023
This test must be deleted so #54651 can pass. It's not possible to click the Create Button anymore after switching to dropdowns. Also, this is only testing that an API is called, so it's not very useful.
michellewzhang
pushed a commit
that referenced
this pull request
Sep 21, 2023
Requires #56537 ### Summary Refactor the create user token page to use existing dropdowns (like [org/integration tokens page](https://santry.sentry.io/settings/developer-settings/new-internal/)). This enforces hierarchy automatically when creating user tokens through the UI. ### Scopes Originally you could select scopes granularly, so you could check `project:admin` but not `project:read`. The dropdowns will include all weaker scopes for the same resource you're selecting. Ideally we would call each option in the dropdown: ```mdx Ideal Current - read - read - write vs. - read + write - admin - admin Note: Admin implies access to everything so includes read + write + any other special scope for that resource e.g. project:releases/org:integrations ``` and explain the hierarchy in the header description with a link to our scope docs. However we still need to overhaul our scope docs so this change will have to come after the docs are complete. ### Before <img width="1267" alt="Screenshot 2023-08-11 at 3 15 13 PM" src="https://github.com/getsentry/sentry/assets/67301797/9e590eff-f839-4678-ab55-ac41610fdc8a"> ### After https://github.com/getsentry/sentry/assets/67301797/f0c1c730-ad51-4977-8b0c-0b026cf3d8b4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test must be deleted so #54651 can pass. It's not possible to click the Create Button anymore after switching to dropdowns. Also, this is only testing that an API is called, so it's not very useful.