Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(on_demand): Support epm and eps operators #56598

Merged
merged 10 commits into from
Sep 27, 2023
Merged

feat(on_demand): Support epm and eps operators #56598

merged 10 commits into from
Sep 27, 2023

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Sep 20, 2023 •
edited
Loading

Fixes #56572

@armenzg armenzg added the WIP label Sep 20, 2023
@armenzg armenzg self-assigned this Sep 20, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 20, 2023
armenzg
armenzg commented Sep 20, 2023
View reviewed changes
src/sentry/snuba/metrics/extraction.py Outdated Show resolved Hide resolved
src/sentry/snuba/metrics/extraction.py Outdated Show resolved Hide resolved
src/sentry/snuba/metrics/fields/snql.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #56598 (233a6b4) into master (0af0645) will increase coverage by 0.00%.
Report is 81 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 233a6b4 differs from pull request most recent head dc75885. Consider uploading reports for the commit dc75885 to get more accurate results

@@           Coverage Diff            @@
##           master   #56598    +/-   ##
========================================
  Coverage   78.63%   78.63%            
========================================
  Files        5083     5084     +1     
  Lines      219080   219212   +132     
  Branches    37093    37113    +20     
========================================
+ Hits       172266   172379   +113     
- Misses      41239    41254    +15     
- Partials     5575     5579     +4
Files Changed Coverage
src/sentry/snuba/metrics/fields/base.py ø
src/sentry/snuba/metrics/utils.py ø
src/sentry/snuba/metrics/extraction.py 100.00%
src/sentry/snuba/metrics/fields/snql.py 100.00%

armenzg
armenzg commented Sep 25, 2023
View reviewed changes
src/sentry/snuba/metrics/extraction.py Outdated Show resolved Hide resolved
src/sentry/snuba/metrics/fields/snql.py Outdated Show resolved Hide resolved
@armenzg armenzg changed the title feat(on_demand_metrics): Support epm operator feat(on_demand): Support epm and eps operators Sep 26, 2023
@armenzg armenzg marked this pull request as ready for review September 26, 2023 18:06
@armenzg armenzg requested a review from a team as a code owner September 26, 2023 18:06
@armenzg armenzg requested a review from a team September 26, 2023 18:06
@armenzg armenzg requested review from a team as code owners September 26, 2023 18:06
@armenzg armenzg requested a review from k-fish September 26, 2023 19:14
jan-auer
jan-auer approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant solution!

The implementation looks good to me and test coverage seems sufficient. Considering that these functions cannot be used from alerts, this should be safe to merge.

src/sentry/snuba/metrics/extraction.py
Comment on lines +126 to +127
"epm": "on_demand_epm",
"eps": "on_demand_eps",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you also add mappings for tpm and tps here, or is that converted somewhere upstream of the extraction module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tpm and tps cannot be used in widgets.
It's a concept within Performance transaction summaries.

@armenzg armenzg merged commit f0df161 into master Sep 27, 2023
49 checks passed
@armenzg armenzg deleted the f2/epm/metric-extraction branch September 27, 2023 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jan-auer jan-auer jan-auer approved these changes

@k-fish k-fish Awaiting requested review from k-fish

Assignees

@armenzg armenzg

Labels
Scope: Backend Automatically applied to PRs that change backend components WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support epm() and eps() for on-demand metrics
2 participants
@armenzg @jan-auer