Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dx): Only show the analytics notice once #56757

Merged

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Sep 22, 2023

Every run of a sentry command greets you with

INFO:The Sentry runner will report development issues to Sentry.io. Use SENTRY_DEVENV_NO_REPORT to avoid reporting issues.

I don't think we need to see this more than once :-)

This is take two of #56752, the mode needed to be w+ to create the file

Every run of a sentry command greets you with

```
INFO:The Sentry runner will report development issues to Sentry.io. Use SENTRY_DEVENV_NO_REPORT to avoid reporting issues.
```

I don't think we need to see this more than once :-)
@evanpurkhiser evanpurkhiser requested a review from a team September 22, 2023 18:27
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 22, 2023
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a+ but this is probably fine

@evanpurkhiser evanpurkhiser merged commit 0b31a76 into master Sep 22, 2023
51 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-dx-only-show-the-analytics-notice-once branch September 22, 2023 21:18
@evanpurkhiser
Copy link
Member Author

ok that's not actually the problem. The problem is that get_sentry_conf does not return a real path (it includes ~)

@evanpurkhiser evanpurkhiser added the Trigger: Revert add to a merged PR to revert it (skips CI) label Sep 22, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 28149bc

getsentry-bot added a commit that referenced this pull request Sep 22, 2023
This reverts commit 0b31a76.

Co-authored-by: evanpurkhiser <1421724+evanpurkhiser@users.noreply.github.com>
RaduW pushed a commit that referenced this pull request Sep 25, 2023
Every run of a sentry command greets you with

```
INFO:The Sentry runner will report development issues to Sentry.io. Use SENTRY_DEVENV_NO_REPORT to avoid reporting issues.
```

I don't think we need to see this more than once :-)

This is take two of GH-56752, the mode needed to be `w+` to create the
file
RaduW pushed a commit that referenced this pull request Sep 25, 2023
This reverts commit 0b31a76.

Co-authored-by: evanpurkhiser <1421724+evanpurkhiser@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants