Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(query-builder): Move base querybuilder to its own file #56761

Closed
wants to merge 3 commits into from
Closed

ref(query-builder): Move base querybuilder to its own file #56761

wants to merge 3 commits into from

Conversation

wmak
Copy link
Member

@wmak wmak commented Sep 22, 2023

  • This moves the base query builder out of the discover file
  • Next up is Renaming QueryBuilder -> DiscoverQueryBuilder
  • Then moving the other builders to inherit from Base instead of Discoveru

@wmak
ref(query-builder): Move base querybuilder to its own file
a7f8c57 
- This moves the base query builder out of the discover file
- Next up is Renaming QueryBuilder -> DiscoverQueryBuilder
- Then moving the other builders to inherit from Base instead of
  Discover
@wmak wmak requested a review from a team September 22, 2023 18:52
@wmak wmak requested a review from a team as a code owner September 22, 2023 18:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 22, 2023
@getsantry
Copy link
Contributor

getsantry bot commented Oct 25, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 25, 2023
@wmak wmak marked this pull request as draft October 27, 2023 15:31
@getsantry getsantry bot closed this Nov 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmak @scttcper