Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Remove ids option from useTeams #57151

Merged
merged 3 commits into from
Oct 2, 2023
Merged

feat(ui): Remove ids option from useTeams #57151

merged 3 commits into from
Oct 2, 2023

Conversation

scttcper
Copy link
Member

  • removes the last ids[] useage
  • use the new useTeamsById instead

depends on #57144 being merged first

@scttcper
feat(ui): Remove ids option from useTeams
1889caa 
- removes the last ids[] useage
- use the new `useTeamsById` instead
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 28, 2023
@scttcper scttcper marked this pull request as ready for review September 28, 2023 23:02
@scttcper scttcper requested a review from a team September 29, 2023 18:40
@malwilley
Copy link
Member

malwilley commented Sep 29, 2023 •
edited
Loading

Can we add a comment urging consumers to use useTeamsById() if possible? Afraid that we will still get a lot of usages of useTeams() where the whole list gets filtered to find the team they want.

JonasBa
JonasBa approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@JonasBa JonasBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and helpful deprecated comment 👏

@scttcper scttcper merged commit 964d5a5 into master Oct 2, 2023
41 checks passed
@scttcper scttcper deleted the scttcper/remove-useteams-id branch October 2, 2023 16:55
@scttcper scttcper added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Oct 2, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 20ecb00

getsentry-bot added a commit that referenced this pull request Oct 2, 2023
@getsentry-bot @scttcper
Revert "feat(ui): Remove ids option from useTeams (#57151)"
20ecb00 
This reverts commit 964d5a5.

Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
scttcper added a commit that referenced this pull request Oct 2, 2023
@scttcper
Revert "Revert "feat(ui): Remove ids option from useTeams (#57151)""
150d83c 
This reverts commit 20ecb00.
@scttcper scttcper mentioned this pull request Oct 2, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@malwilley malwilley malwilley approved these changes

@JonasBa JonasBa JonasBa approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scttcper @malwilley @getsentry-bot @JonasBa