Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(feedback): update blueprint proposal #57530

Closed
wants to merge 2 commits into from
Closed

ref(feedback): update blueprint proposal #57530

wants to merge 2 commits into from

Conversation

JoshFerge
Copy link
Member

  • moves feedback into contexts object
  • moves replay_id into replay context object

@JoshFerge JoshFerge requested a review from a team as a code owner October 4, 2023 23:05
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 4, 2023
cmanallen
cmanallen requested changes Oct 5, 2023
View reviewed changes
src/sentry/feedback/blueprints/api.md Outdated
| event_id | optional[string] | Omitted IDs are internally generated. |
| contexts | optional[object] | - |
| replay | optional[object] | - |
| replay.replay_id | optional[string] | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be contexts.replay

src/sentry/feedback/blueprints/api.md Outdated
| event_id | optional[string] | Omitted IDs are internally generated. |
| contexts | optional[object] | - |
| replay | optional[object] | - |
| replay.replay_id | optional[string] | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example beneath this section should be updated as well.

@getsantry
Copy link
Contributor

getsantry bot commented Oct 27, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 27, 2023
@getsantry getsantry bot closed this Nov 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmanallen cmanallen cmanallen requested changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshFerge @cmanallen