fix(hc): Silo fixes for OrganizationAlertRuleAvailableActionIndexEndpoint #57949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint Adapt OrganizationAlertRuleAvailableActionIndexEndpoint and get_available_action_integrations_for_org to run in the region silo. Introduce a prepare_sentry_app_components method to AppService. Remove the method of the same name from the SentryAppInstallation model. (It previously dispatched to the same module-level function that AppService now calls. The model method was called nowhere else.) Mark OrganizationAlertRuleAvailableActionIndexEndpointTest as stable. Change setup to pass RPC models as needed.
github-actions
bot
added
the
Scope: Backend
markstory
approved these changes
Oct 12, 2023
| from sentry.models.integrations.sentry_app_installation import prepare_sentry_app_components | ||
|
|
||
| installation = SentryAppInstallation.objects.get(id=installation_id) | ||
| values = json.loads(values_json) if values_json else None |
There was a problem hiding this comment.
Should we handle json parsing failures here? We are getting a JSON blob off the wire.
There was a problem hiding this comment.
That's a good idea, and one that we should probably generalize to other RPC methods. (Grep for data_json to see those cases.)
However, considering that it's not used by the one call site and may remain unused indefinitely, I'll just remove it. We can always add it later (with good validation) when we need to.
RyanSkonnord
deleted the
hc-fix-organization_alert-rule-available-action-index
branch
RyanSkonnord
added
the
Trigger: Revert
|
revert failed (conflict? already reverted?) -- check the logs |
RyanSkonnord
added a commit
that referenced
this pull request
Oct 13, 2023
#58091) Rolling back #57949 to address SENTRY-16NH (https://sentry.sentry.io/issues/4544284664/) The original fix should be mostly okay but `RpcSentryAppComponent` should not have `Mapping[str, Any]` as a field, which seems to be the root of the problem.
RyanSkonnord
added a commit
that referenced
this pull request
Oct 16, 2023
Restore #57949, which was reverted by #58091. Fix SENTRY-16NH (https://sentry.sentry.io/issues/4544284664/). Adapt OrganizationAlertRuleAvailableActionIndexEndpoint and get_available_action_integrations_for_org to run in the region silo. Introduce a prepare_sentry_app_components method to AppService. Remove the method of the same name from the SentryAppInstallation model. (It previously dispatched to the same module-level function that AppService now calls. The model method was called nowhere else.) Mark OrganizationAlertRuleAvailableActionIndexEndpointTest as stable. Change setup to pass RPC models as needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt OrganizationAlertRuleAvailableActionIndexEndpoint and get_available_action_integrations_for_org to run in the region silo.
Introduce a prepare_sentry_app_components method to AppService. Remove the method of the same name from the SentryAppInstallation model. (It previously dispatched to the same module-level function that AppService now calls. The model method was called nowhere else.)
Mark OrganizationAlertRuleAvailableActionIndexEndpointTest as stable. Change setup to pass RPC models as needed.