ref(hc): Advisory lock #57958
Merged
ref(hc): Advisory lock #57958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
markstory
approved these changes
Oct 12, 2023
| @@ -76,7 +76,7 @@ def get_conflicting_unique_columns( | |||
| scope = category.get_scope() | |||
| scope_controlled_columns: List[str] | |||
| if scope == scope.USER_SCOPE: | |||
| scope_controlled_columns = [get_foreign_key_column(destination, User)] | |||
| scope_controlled_columns = ["ident", get_foreign_key_column(destination, User)] | |||
There was a problem hiding this comment.
Is it worth leaving a comment here about this being for AuthIdentity? I would see this causing problems in the future if we have another user scope replicated model.
There was a problem hiding this comment.
You are correct! I'll add a comment on my next pass.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
PR reverted: 4b442eb |
getsentry-bot
added a commit
that referenced
this pull request
Oct 12, 2023
This reverts commit fa0cf78. Co-authored-by: corps <593850+corps@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass 2 on #57877
Added better handling for operational error on lock timeout (something lost in the original PR), and also fixed the outbox contention issues around auth identity.