Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replays): Accept timestamp parameter when calculating accessibility issues #60983

Merged
merged 8 commits into from
Dec 4, 2023

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Dec 1, 2023

Allows point in time accessibility analysis.

Epic: #55501

@cmanallen cmanallen requested a review from a team as a code owner December 1, 2023 19:10
Copy link

sentry-io bot commented Dec 1, 2023

🚀 Sentry Issue Report

You modified these files in this pull request and we noticed these issues associated with them.

📄 src/sentry/replays/endpoints/project_replay_accessibility_issues.py

Issue Additional Info
‼️ ValueError: An error occurred: upstream connect error or disconnect/reset before headers. reset reason: conne... /api/0/projects/{organizatio... Handled: True Event Count: 51 Users: 4

Did you find this useful? React with a 👍 or 👎 or let us know in #proj-github-pr-comments

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 1, 2023
@cmanallen
Copy link
Member Author

At sentry bot. I'm cool with it.

Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooo

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #60983 (4ca931a) into master (8163b0c) will increase coverage by 0.00%.
Report is 6 commits behind head on master.
The diff coverage is 84.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #60983   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files        5183     5185    +2     
  Lines      227198   227234   +36     
  Branches    38192    38197    +5     
=======================================
+ Hits       184037   184079   +42     
+ Misses      37526    37523    -3     
+ Partials     5635     5632    -3     
Files Coverage Δ
src/sentry/replays/constants.py 100.00% <100.00%> (ø)
src/sentry/replays/usecases/reader.py 93.40% <100.00%> (+0.14%) ⬆️
src/sentry/replays/usecases/segment.py 89.47% <89.47%> (ø)
...s/endpoints/project_replay_accessibility_issues.py 73.68% <73.33%> (-0.92%) ⬇️

... and 9 files with indirect coverage changes

@bruno-garcia
Copy link
Member

@cmanallen please add a link to the ticket/epic this refers to to the PR description

@cmanallen cmanallen merged commit 8b63a74 into master Dec 4, 2023
49 of 50 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-compute-segement-from-timestamp branch December 4, 2023 19:42
Copy link

sentry-io bot commented Dec 4, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: No segment could be found for timestamp. /api/0/projects/{organization_slug}/{project_sl... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants