Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rr6): Add shims for React Router 3 → 6 #70632

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented May 9, 2024

Copy link

codecov bot commented May 10, 2024

Bundle Report

Changes will increase total bundle size by 203.94kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 30.26MB 203.94kB ⬆️

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 4248626 to eec769b Compare May 10, 2024 20:28
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from eec769b to 927c27e Compare May 10, 2024 21:34
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 927c27e to 1bf2737 Compare May 15, 2024 20:17
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 1bf2737 to 54530de Compare May 22, 2024 22:52
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 54530de to 1cf3c29 Compare May 23, 2024 03:32
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 1cf3c29 to 131764a Compare May 23, 2024 22:14
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 131764a to 7ce5ef3 Compare May 24, 2024 16:32
evanpurkhiser added a commit that referenced this pull request May 29, 2024
This module imports a TON of stuff, STARFISH_FIELDS is used by
discover/fields. By moving this out we can reduce the import graph
generated for chartcuterie by a magnitude of a few MBs.

This is also needed for GH-70632
evanpurkhiser added a commit that referenced this pull request May 29, 2024
This module imports a TON of stuff, STARFISH_FIELDS is used by
discover/fields. By moving this out we can reduce the import graph
generated for chartcuterie by a magnitude of a few MBs.

This is also needed for GH-70632
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 7ce5ef3 to d732fd7 Compare May 29, 2024 05:38
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 25.71429% with 130 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
static/app/utils/browserHistory.tsx 3.12% 31 Missing ⚠️
static/app/utils/useRouter.tsx 4.00% 22 Missing and 2 partials ⚠️
static/app/utils/reactRouter6Compat/router.tsx 66.66% 18 Missing ⚠️
static/app/utils/reactRouter6Compat/location.tsx 0.00% 14 Missing ⚠️
static/app/utils/useRoutes.tsx 7.69% 10 Missing and 2 partials ⚠️
static/app/utils/useNavigate.tsx 0.00% 5 Missing and 2 partials ⚠️
.../app/views/settings/components/settingsNavItem.tsx 22.22% 7 Missing ⚠️
static/app/utils/useLocation.tsx 14.28% 4 Missing and 2 partials ⚠️
static/app/main.tsx 0.00% 4 Missing ⚠️
static/app/utils/useParams.tsx 25.00% 1 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70632      +/-   ##
==========================================
- Coverage   78.16%   78.13%   -0.03%     
==========================================
  Files        6894     6896       +2     
  Lines      306749   306914     +165     
  Branches    52794    52825      +31     
==========================================
+ Hits       239759   239796      +37     
- Misses      60602    60718     +116     
- Partials     6388     6400      +12     

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from d732fd7 to 2330fd6 Compare May 30, 2024 15:49
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 925467d to cab1c54 Compare August 6, 2024 20:44
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 2f5afd6 to 6aef004 Compare August 19, 2024 19:05
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 6aef004 to 24787f8 Compare August 20, 2024 15:48
@evanpurkhiser evanpurkhiser changed the title ref(routes): WIP react router 6 ref(js): Upgrade React Router 3 → 6 Aug 21, 2024
@evanpurkhiser evanpurkhiser changed the title ref(js): Upgrade React Router 3 → 6 feat(rr6): Upgrade React Router 3 → 6 Aug 21, 2024
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 98899af to ed5a223 Compare August 21, 2024 23:48
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from ed5a223 to 1a5d79e Compare August 21, 2024 23:54
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 1a5d79e to df8ee00 Compare August 22, 2024 02:43
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from df8ee00 to 813aaeb Compare August 26, 2024 15:22
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/wip-react-router-6 branch from 813aaeb to c5f3199 Compare August 26, 2024 18:43
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work

@evanpurkhiser evanpurkhiser merged commit 57035b3 into master Aug 27, 2024
41 of 42 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/wip-react-router-6 branch August 27, 2024 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@evanpurkhiser evanpurkhiser changed the title feat(rr6): Upgrade React Router 3 → 6 feat(rr6): Add shims for React Router 3 → 6 Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants