-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rr6): Add shims for React Router 3 → 6 #70632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
May 9, 2024
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 10, 2024 19:03
a91f7b6
to
cba5566
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 10, 2024 20:07
ce02305
to
4248626
Compare
Bundle ReportChanges will increase total bundle size by 203.94kB ⬆️
|
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 10, 2024 20:28
4248626
to
eec769b
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 10, 2024 21:34
eec769b
to
927c27e
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 15, 2024 20:17
927c27e
to
1bf2737
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 22, 2024 22:52
1bf2737
to
54530de
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 23, 2024 03:32
54530de
to
1cf3c29
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 23, 2024 22:14
1cf3c29
to
131764a
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 24, 2024 16:32
131764a
to
7ce5ef3
Compare
evanpurkhiser
added a commit
that referenced
this pull request
May 29, 2024
This module imports a TON of stuff, STARFISH_FIELDS is used by discover/fields. By moving this out we can reduce the import graph generated for chartcuterie by a magnitude of a few MBs. This is also needed for GH-70632
evanpurkhiser
added a commit
that referenced
this pull request
May 29, 2024
This module imports a TON of stuff, STARFISH_FIELDS is used by discover/fields. By moving this out we can reduce the import graph generated for chartcuterie by a magnitude of a few MBs. This is also needed for GH-70632
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 29, 2024 05:38
7ce5ef3
to
d732fd7
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #70632 +/- ##
==========================================
- Coverage 78.16% 78.13% -0.03%
==========================================
Files 6894 6896 +2
Lines 306749 306914 +165
Branches 52794 52825 +31
==========================================
+ Hits 239759 239796 +37
- Misses 60602 60718 +116
- Partials 6388 6400 +12 |
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
May 30, 2024 15:49
d732fd7
to
2330fd6
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 6, 2024 20:44
925467d
to
cab1c54
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 19, 2024 19:05
2f5afd6
to
6aef004
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 20, 2024 15:48
6aef004
to
24787f8
Compare
evanpurkhiser
changed the title
ref(routes): WIP react router 6
ref(js): Upgrade React Router 3 → 6
Aug 21, 2024
evanpurkhiser
changed the title
ref(js): Upgrade React Router 3 → 6
feat(rr6): Upgrade React Router 3 → 6
Aug 21, 2024
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 21, 2024 23:48
98899af
to
ed5a223
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 21, 2024 23:54
ed5a223
to
1a5d79e
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 22, 2024 02:43
1a5d79e
to
df8ee00
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 26, 2024 15:22
df8ee00
to
813aaeb
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 26, 2024 18:43
813aaeb
to
c5f3199
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/wip-react-router-6
branch
from
August 26, 2024 19:59
c5f3199
to
6015963
Compare
scttcper
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work
evanpurkhiser
changed the title
feat(rr6): Upgrade React Router 3 → 6
feat(rr6): Add shims for React Router 3 → 6
Oct 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tracked by https://github.com/getsentry/frontend-tsc/issues/23