Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiles): Send profile chunks to the chunk route on vroom #70714

Merged
merged 1 commit into from
May 21, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented May 12, 2024

Send profile chunks to the right endpoint so they get stored properly.

getsentry/vroom#463
getsentry/snuba#5895

@phacops phacops requested a review from a team as a code owner May 12, 2024 14:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.03%. Comparing base (751ef4a) to head (57ae187).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70714      +/-   ##
==========================================
+ Coverage   79.77%   80.03%   +0.26%     
==========================================
  Files        6676     6506     -170     
  Lines      298989   290763    -8226     
  Branches    50103    50103              
==========================================
- Hits       238507   232706    -5801     
+ Misses      60045    57620    -2425     
  Partials      437      437              
Files Coverage Δ
src/sentry/profiles/task.py 58.54% <0.00%> (-0.11%) ⬇️

... and 179 files with indirect coverage changes

@phacops phacops merged commit b9dc7dd into master May 21, 2024
49 of 50 checks passed
@phacops phacops deleted the pierre/profile-chunks-to-new-storage-endpoint branch May 21, 2024 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants