Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change powershell tag #72803

Closed
wants to merge 4 commits into from

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Jun 14, 2024

The tag has been changed in the SDK to sentry.dotnet.powershell

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@vaind vaind force-pushed the chore/change-powershell-tag branch from e072062 to 6c57f4a Compare June 14, 2024 19:01
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (57954f5) to head (6c57f4a).
Report is 754 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72803      +/-   ##
==========================================
- Coverage   78.05%   78.05%   -0.01%     
==========================================
  Files        6599     6599              
  Lines      294321   294321              
  Branches    50754    50754              
==========================================
- Hits       229732   229724       -8     
- Misses      58351    58358       +7     
- Partials     6238     6239       +1     
Files Coverage Δ
src/sentry/utils/tag_normalization.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Jul 6, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jul 6, 2024
@vaind
Copy link
Contributor Author

vaind commented Jul 6, 2024

Not stale

@getsantry getsantry bot closed this Jul 14, 2024
@bruno-garcia bruno-garcia reopened this Jul 15, 2024
@bruno-garcia bruno-garcia enabled auto-merge (squash) July 15, 2024 14:41
@bruno-garcia
Copy link
Member

CI isn't happy with external PRs?
I opened one: #74373

@vaind vaind closed this Jul 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants