Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(similarity): Increase timeout for bulk record insertion #73405

Closed
wants to merge 3 commits into from

Conversation

jangjodi
Copy link
Member

@jangjodi jangjodi commented Jun 26, 2024

Increase timeout for seer bulk record insertion endpoint in an option
Previously was 1000 ms, now 3000 ms

Also change deletion timeout to use option

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (3ba26f2) to head (b7b5976).

Current head b7b5976 differs from pull request most recent head 0849e7b

Please upload reports for the commit 0849e7b to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #73405       +/-   ##
===========================================
+ Coverage   53.70%   78.01%   +24.30%     
===========================================
  Files        2913     6634     +3721     
  Lines      181367   296596   +115229     
  Branches    29894    48583    +18689     
===========================================
+ Hits        97412   231394   +133982     
+ Misses      79581    58911    -20670     
- Partials     4374     6291     +1917     
Files Coverage Δ
src/sentry/options/defaults.py 100.00% <ø> (ø)
src/sentry/seer/similarity/grouping_records.py 84.05% <83.33%> (+41.63%) ⬆️

... and 5712 files with indirect coverage changes

@jangjodi jangjodi marked this pull request as ready for review June 27, 2024 15:14
@jangjodi jangjodi requested a review from a team June 27, 2024 15:14
@getsantry
Copy link
Contributor

getsantry bot commented Jul 19, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jul 19, 2024
@getsantry getsantry bot closed this Jul 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants