Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikhars/ref/metrics query rollover #73472

Closed
wants to merge 8 commits into from

Conversation

nikhars
Copy link
Member

@nikhars nikhars commented Jun 27, 2024

No description provided.

@nikhars nikhars added the Do Not Merge Don't merge label Jun 27, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 44.92308% with 179 lines in your changes missing coverage. Please review.

Project coverage is 56.62%. Comparing base (5aeaf13) to head (e9e39d5).
Report is 155 commits behind head on master.

Current head e9e39d5 differs from pull request most recent head 8e388c6

Please upload reports for the commit 8e388c6 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #73472       +/-   ##
===========================================
- Coverage   78.01%   56.62%   -21.39%     
===========================================
  Files        6632     6597       -35     
  Lines      296035   296165      +130     
  Branches    50986    51044       +58     
===========================================
- Hits       230957   167717    -63240     
- Misses      58794   123765    +64971     
+ Partials     6284     4683     -1601     
Files Coverage Δ
src/sentry/search/events/datasets/spans_metrics.py 40.33% <50.00%> (-45.78%) ⬇️
src/sentry/snuba/metrics/fields/snql.py 40.74% <50.00%> (-54.45%) ⬇️
src/sentry/snuba/metrics/fields/snql_base.py 55.55% <55.55%> (ø)
src/sentry/snuba/metrics/mqb_query_transformer.py 13.06% <20.00%> (-79.40%) ⬇️
src/sentry/snuba/metrics/query_builder.py 37.71% <42.85%> (-52.63%) ⬇️
src/sentry/snuba/metrics/datasource.py 24.93% <16.66%> (-61.79%) ⬇️
src/sentry/sentry_metrics/utils.py 38.61% <47.05%> (-57.09%) ⬇️
src/sentry/snuba/metrics/fields/base.py 53.42% <65.15%> (-37.62%) ⬇️
src/sentry/snuba/metrics/fields/snql_v2.py 39.22% <39.22%> (ø)

... and 2094 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Jul 20, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jul 20, 2024
@getsantry getsantry bot closed this Jul 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Do Not Merge Don't merge Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant