chore(similarity): Add metric for no stacktrace frame #73514
Conversation
github-actions
bot
added
the
Scope: Backend
| "grouping.similarity.no_contributing_stacktrace_frame", | ||
| # TODO: Consider lowering this (in all the spots this metric is | ||
| # collected) once we roll Seer grouping out more widely | ||
| sample_rate=1.0, |
There was a problem hiding this comment.
Not necessary as a part of this change - we have a handful of these high sample rates, thoughts on having a single ML grouping sample rate setting somewhere that we can lower/change over time?
There was a problem hiding this comment.
Sounds good, thanks @lobsterkatie
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73514 +/- ##
==========================================
- Coverage 78.02% 78.01% -0.01%
==========================================
Files 6638 6638
Lines 296818 296821 +3
Branches 51115 51116 +1
==========================================
- Hits 231582 231572 -10
- Misses 58965 58976 +11
- Partials 6271 6273 +2
|
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Add metric for when an event has a non-empty stacktrace string that we'd send to seer, but has no stacktrace frames
Limit metric to backend calls