Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(trace) use proper graph edges to construct the trace graph #73522

Closed
wants to merge 3 commits into from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 28, 2024

Implementing edges using an array was naive and it makes for a very inefficient querying of the tree which is getting in the way as I'm trying to implement search across the entire tree (not just the visible parts). When we do that, we'll need an efficient way to query the tree and resolve the nodes so that we can determine if the node is visible or of we need to expand to its path.

Copy link

sentry-io bot commented Jun 28, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx

Function Unhandled Issue
findInTreeFromSegment TypeError: Node path must be in the format of type-id /performance/trace/:tra...
Event Count: 1 Affected Users: 11

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 28, 2024
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 82.58065% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (48e48f4) to head (09d2bce).
Report is 2114 commits behind head on master.

Files Patch % Lines
...formance/newTraceDetails/traceModels/traceTree.tsx 83.91% 23 Missing ⚠️
...raceDetails/traceDrawer/tabs/trace/generalInfo.tsx 40.00% 3 Missing ⚠️
...ic/app/views/performance/newTraceDetails/trace.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #73522    +/-   ##
========================================
  Coverage   78.01%   78.01%            
========================================
  Files        6634     6636     +2     
  Lines      296774   296860    +86     
  Branches    51111    51124    +13     
========================================
+ Hits       231533   231608    +75     
- Misses      58854    58979   +125     
+ Partials     6387     6273   -114     
Files Coverage Δ
...rmance/newTraceDetails/traceDrawer/traceDrawer.tsx 54.82% <100.00%> (ø)
...ic/app/views/performance/newTraceDetails/trace.tsx 59.90% <83.33%> (+0.38%) ⬆️
...raceDetails/traceDrawer/tabs/trace/generalInfo.tsx 55.55% <40.00%> (-0.97%) ⬇️
...formance/newTraceDetails/traceModels/traceTree.tsx 69.14% <83.91%> (-1.34%) ⬇️

... and 101 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Jul 20, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jul 20, 2024
@JonasBa JonasBa removed the Stale label Jul 20, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Aug 11, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 11, 2024
@getsantry getsantry bot closed this Aug 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant