-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(trace) use proper graph edges to construct the trace graph #73522
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73522 +/- ##
========================================
Coverage 78.01% 78.01%
========================================
Files 6634 6636 +2
Lines 296774 296860 +86
Branches 51111 51124 +13
========================================
+ Hits 231533 231608 +75
- Misses 58854 58979 +125
+ Partials 6387 6273 -114
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Implementing edges using an array was naive and it makes for a very inefficient querying of the tree which is getting in the way as I'm trying to implement search across the entire tree (not just the visible parts). When we do that, we'll need an efficient way to query the tree and resolve the nodes so that we can determine if the node is visible or of we need to expand to its path.