docs(useQuery): Write a story that visually shows useQuery loading/error/success states #73600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror/success states
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73600 +/- ##
==========================================
+ Coverage 68.90% 78.02% +9.12%
==========================================
Files 6638 6639 +1
Lines 296910 296912 +2
Branches 51133 51133
==========================================
+ Hits 204589 231675 +27086
+ Misses 85601 58960 -26641
+ Partials 6720 6277 -443
|
malwilley
reviewed
Jul 18, 2024
| <Fragment> | ||
| <p> | ||
| It seems like you can get really far by checking BOTH{' '} | ||
| <code>isFetching || isLoading</code> when you are waiting for the first render, |
There was a problem hiding this comment.
I not sure we should encourage checking for isFetching || isLoading, since you'll lose the benefits of background refetches if you do so
There was a problem hiding this comment.
i'll make more examples!
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Relates to #76407 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's always been some slight confusion, and lack of clear examples, when it comes to using
isFetchingandisLoadingfrom react-query. Also we're not super consistent on the names when we create our own loading state variables, which just adds to the confusion...So I made a story that illustrates a few examples where we "load" in data slowly enough to see the state changes happening. Turns out that checking both
isFetchingandisLoadingis probably what we should do all the time.<Suspense>is also a killer feature to leverage.