-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(seer grouping): Add module
values to Seer stacktrace strings
#73675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73675 +/- ##
=======================================
Coverage 78.07% 78.07%
=======================================
Files 6654 6654
Lines 297329 297329
Branches 51166 51166
=======================================
+ Hits 232135 232139 +4
+ Misses 58810 58807 -3
+ Partials 6384 6383 -1
|
035720f
to
7136f63
Compare
d995ca7
to
d3ef329
Compare
7136f63
to
925e8ea
Compare
d3ef329
to
88e2647
Compare
88e2647
to
625d07f
Compare
625d07f
to
78ee0b9
Compare
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
UPDATE: Our initial analysis seems to indicate that making this change could lead to a fair number of false (well, false according to the current logic, anyway) positives, so we're going to hold off merging this for now. Moving it back to draft until we're sure what we want to do.
This PR adds each frame's
module
value to the stacktrace string we send to Seer, in hopes of increasing the accuracy of the model.