Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(seer grouping): Add module values to Seer stacktrace strings #73675

Closed

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jul 2, 2024

UPDATE: Our initial analysis seems to indicate that making this change could lead to a fair number of false (well, false according to the current logic, anyway) positives, so we're going to hold off merging this for now. Moving it back to draft until we're sure what we want to do.


This PR adds each frame's module value to the stacktrace string we send to Seer, in hopes of increasing the accuracy of the model.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (cdc03d3) to head (78ee0b9).
Report is 855 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73675   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files        6654     6654           
  Lines      297329   297329           
  Branches    51166    51166           
=======================================
+ Hits       232135   232139    +4     
+ Misses      58810    58807    -3     
+ Partials     6384     6383    -1     
Files Coverage Δ
src/sentry/seer/similarity/utils.py 98.57% <100.00%> (-1.43%) ⬇️

... and 6 files with indirect coverage changes

@lobsterkatie lobsterkatie force-pushed the kmclb-only-send-20-minified-js-frames-to-seer branch from 035720f to 7136f63 Compare July 2, 2024 20:21
@lobsterkatie lobsterkatie force-pushed the kmclb-add-module-to-seer-stacktrace-string branch from d995ca7 to d3ef329 Compare July 2, 2024 20:22
@lobsterkatie lobsterkatie force-pushed the kmclb-only-send-20-minified-js-frames-to-seer branch from 7136f63 to 925e8ea Compare July 2, 2024 20:45
@lobsterkatie lobsterkatie force-pushed the kmclb-add-module-to-seer-stacktrace-string branch from d3ef329 to 88e2647 Compare July 2, 2024 20:45
Base automatically changed from kmclb-only-send-20-minified-js-frames-to-seer to master July 2, 2024 21:24
@lobsterkatie lobsterkatie force-pushed the kmclb-add-module-to-seer-stacktrace-string branch from 88e2647 to 625d07f Compare July 2, 2024 21:26
@lobsterkatie lobsterkatie marked this pull request as ready for review July 2, 2024 21:28
@lobsterkatie lobsterkatie requested a review from a team as a code owner July 2, 2024 21:28
@getsantry
Copy link
Contributor

getsantry bot commented Jul 25, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jul 25, 2024
@getsantry getsantry bot closed this Aug 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants