fix(settings): Change search org settings routes #73707
Conversation
routes for some settings are defined aas `/settings/:orgId/` and for some reason normalizeUrl is sending users to the root settings page. Adjust the route to send them to the right page. fixes #73692
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 1.01kB ⬆️
|
| const results = | ||
| fuzzy?.search(query).map<Result>(value => { | ||
| const {item, ...rest} = value; | ||
| if (isCustomerDomain && item.route === '/settings/:orgId/') { | ||
| item.route = '/settings/organization/:orgId/'; |
There was a problem hiding this comment.
I don't remember there being a route for /settings/organization/:orgId. Using this route in the UI results in a redirect to /settings/organization/projects/:orgId/ which triggers a bunch of 403 errors as requests are made to the slug organization.
I think instead you want a redirect target of /settings/organization/ or /settings/:orgId/
There was a problem hiding this comment.
for some reason /settings/organization/#anchor-tag is being normalized to just /settings/ however /settings/organization/:orgId/ does get normalized to the right place. This was also the fix @roggenkemper came up with in #73697 (review)
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
routes for some settings are defined aas
/settings/:orgId/and for some reason normalizeUrl is sending users to the root settings page. Adjust the route to send them to the right page.fixes #73692