fix(performance): txn summary "has" queries should fall back #73767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `has` queries in the Transaction Summary filter causes an empty Duration Breakdown, although samples are returned. This happens because the metrics dataset only contains a subset of tags (to make cardinality manageable), so only those tags will return metrics data with `has` queries. Since the tags for each metric are inconsistent, instead remove support for `has` queries to the metrics dataset, falling back to the transactions dataset instead. That way queries will return metric results from the indexed transaction data instead of empty results. Fixes #73591
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73767 +/- ##
==========================================
- Coverage 78.09% 78.09% -0.01%
==========================================
Files 6654 6648 -6
Lines 297526 297576 +50
Branches 51189 51211 +22
==========================================
+ Hits 232344 232383 +39
- Misses 58902 58914 +12
+ Partials 6280 6279 -1
|
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
hasqueries in the Transaction Summary filter causes an empty Duration Breakdown, although samples are returned. This happens because the metrics dataset only contains a subset of tags (to make cardinality manageable), so only those tags will return metrics data withhasqueries.Since the tags for each metric are inconsistent, instead remove support for
hasqueries to the metrics dataset, which will cause a fallback to the transactions dataset instead. That way queries will return metric results from the indexed transaction data instead of empty results.Fixes #73591