-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(alerts): Change copy of mute alert link #73803
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73803 +/- ##
==========================================
+ Coverage 74.95% 78.08% +3.12%
==========================================
Files 6654 6648 -6
Lines 297330 297435 +105
Branches 51166 51195 +29
==========================================
+ Hits 222859 232239 +9380
+ Misses 67722 58812 -8910
+ Partials 6749 6384 -365 |
Hi I'm sorry I didn't see this before, but this text change is incorrect. You can see the original implementation here for the front end, and here for the issue alert email. (digests and metric alerts) We pass the query param As far as I can see this hasn't changed since it was originally added so all emails would have the |
PR reverted: 83e5b72 |
This reverts commit 578516f. Co-authored-by: mifu67 <83109586+mifu67@users.noreply.github.com>
Change the link text for muting email alerts from "Mute this alert" to "Mute this alert for everyone." Fixes GH-69792
This reverts commit 578516f. Co-authored-by: mifu67 <83109586+mifu67@users.noreply.github.com>
Change the link text for muting email alerts from "Mute this alert" to "Mute this alert for everyone."
Fixes GH-69792